Xfce Wiki

Sub domains
 

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revisionPrevious revision
Next revision		Previous revision
Next revisionBoth sides next revision
dev:howto:contribute [2013/02/02 15:54] – jannisdev:howto:contribute [2013/02/02 16:04] – [Contribution Process] jannis
Line 46: Line 46:
   * Make sure to pull in the latest Xfce master frequently.   * Make sure to pull in the latest Xfce master frequently.
   * Keep commits clean:   * Keep commits clean:
-    * Make incremental, atomic changes (one aspect at a time) +    * Make incremental, atomic changes (one aspect at a time). 
-    * Keep code working after every commit +    * Keep code working after every commit. 
-    * Comment the code you write +    * Comment the code you write. 
-    * Write commit messages using the standard Git message format +    * Write commit messages using the standard Git message format. 
-    * Don't fear the rebase (against the Xfce master branch)+    * Don't fear the rebase (against the Xfce master branch).
  
 === 3. Push === === 3. Push ===
Line 75: Line 75:
 Fill out the SUBJECT and MESSAGE by briefly describing what you are submitting. Then save the file and close the editor. ''git send-email'' will send your patch set to the ''xfce4-dev@xfce.org'' mailing list in the form of the above cover letter email, followed by an additional email for each commit in your branch. These mails will each include the commit message and the commit diff as plain text. Fill out the SUBJECT and MESSAGE by briefly describing what you are submitting. Then save the file and close the editor. ''git send-email'' will send your patch set to the ''xfce4-dev@xfce.org'' mailing list in the form of the above cover letter email, followed by an additional email for each commit in your branch. These mails will each include the commit message and the commit diff as plain text.
  
-== Configuring ''git send-email'' ==+**Configuring ''git send-email''**
  
 You will need to configure a number of items for ''git send-email'' to function usefully. At minimum, you need to tell it how to actually send emails. This can be done with the following You will need to configure a number of items for ''git send-email'' to function usefully. At minimum, you need to tell it how to actually send emails. This can be done with the following
Line 100: Line 100:
   * Testing the changes.   * Testing the changes.
   * Comments on:   * Comments on:
-    * Coding style and bad code design +    * Coding style and bad code design. 
-    * Potential issues +    * Potential issues. 
-    * Possible side-effects+    * Possible side-effects.
  
 The reviews will be sent as replies to your cover letter and patch emails. Thanks to having the patches included in your submission as plain text, they can be commented on in-line. The reviews will be sent as replies to your cover letter and patch emails. Thanks to having the patches included in your submission as plain text, they can be commented on in-line.