Differences
This shows you the differences between two versions of the page.
| Both sides previous revisionPrevious revision | Next revisionBoth sides next revision | ||
| dev:howto:contribute [2013/02/02 15:55] – jannis | dev:howto:contribute [2013/02/02 16:04] – [Contribution Process] jannis | ||
|---|---|---|---|
| Line 46: | Line 46: | ||
| * Make sure to pull in the latest Xfce master frequently. | * Make sure to pull in the latest Xfce master frequently. | ||
| * Keep commits clean: | * Keep commits clean: | ||
| - | * Make incremental, | + | * Make incremental, |
| - | * Keep code working after every commit | + | * Keep code working after every commit. |
| - | * Comment the code you write | + | * Comment the code you write. |
| - | * Write commit messages using the standard Git message format | + | * Write commit messages using the standard Git message format. |
| - | * Don't fear the rebase (against the Xfce master branch) | + | * Don't fear the rebase (against the Xfce master branch). |
| === 3. Push === | === 3. Push === | ||
| Line 100: | Line 100: | ||
| * Testing the changes. | * Testing the changes. | ||
| * Comments on: | * Comments on: | ||
| - | * Coding style and bad code design | + | * Coding style and bad code design. |
| - | * Potential issues | + | * Potential issues. |
| - | * Possible side-effects | + | * Possible side-effects. |
| The reviews will be sent as replies to your cover letter and patch emails. Thanks to having the patches included in your submission as plain text, they can be commented on in-line. | The reviews will be sent as replies to your cover letter and patch emails. Thanks to having the patches included in your submission as plain text, they can be commented on in-line. | ||