Differences
This shows you the differences between two versions of the page.
Both sides previous revisionPrevious revisionNext revision | Previous revisionLast revisionBoth sides next revision | ||
dev:xfdesktop:port-to-gio-progress [2010/10/19 13:22] – 217.229.78.181 | dev:xfdesktop:port-to-gio-progress [2010/10/24 17:46] – 217.229.124.132 | ||
---|---|---|---|
Line 23: | Line 23: | ||
==== xfdesktop-file-icon-manager.{c, | ==== xfdesktop-file-icon-manager.{c, | ||
- | |||
- | === xfdesktop_file_icon_menu_mime_app_executed() === | ||
- | |||
- | Use '' | ||
- | instead of '' | ||
- | before and after this call (similar to how Thunar does it). | ||
- | |||
- | === xfdesktop_menu_item_from_mime_handler() === | ||
- | |||
- | Replace this method with a similar one based on '' | ||
- | '' | ||
- | |||
- | === xfdesktop_file_icon_menu_other_app() === | ||
- | |||
- | Again, we only need the '' | ||
- | Replace '' | ||
- | and '' | ||
- | |||
- | === xfdesktop_file_icon_menu_create_launcher() === | ||
- | |||
- | Use a '' | ||
- | the file URI. Feed exo-desktop-item-edit with the URI instead of a local path. | ||
- | The function '' | ||
- | xfce4-panel/ | ||
- | this. | ||
- | |||
- | === xfdesktop_file_icon_create_file_error() === | ||
- | |||
- | Remove this function. | ||
=== xfdesktop_file_icon_interactive_job_ask() === | === xfdesktop_file_icon_interactive_job_ask() === | ||
Remove this function. | Remove this function. | ||
- | |||
- | === xfdesktop_file_icon_template_item_activated() === | ||
- | |||
- | TODO: This needs more thought. Thunar implements the same functionality, | ||
- | maybe we can reuse its implementation through D-Bus. If not, then at least | ||
- | the ThunarVFS stuff should be replaced with '' | ||
- | calls to '' | ||
- | be replaced with Thunar D-Bus method calls. | ||
- | |||
- | === info_compare() === | ||
- | |||
- | If this is still needed after the other refactorings, | ||
- | '' | ||
- | |||
- | === xfdesktop_file_icon_menu_fill_template_menu() === | ||
- | |||
- | Use '' | ||
- | ThunarVFS structures. Maybe we can reuse some code from Thunar implementing | ||
- | the same thing. | ||
- | |||
- | === xfdesktop_file_icon_manager_populate_context_menu() === | ||
- | |||
- | Use '' | ||
- | Use '' | ||
- | '' | ||
- | |||
- | === xfdesktop_file_icon_manager_add_icon() === | ||
- | |||
- | Use '' | ||
- | |||
- | === xfdesktop_file_icon_manager_add_regular_icon() === | ||
- | |||
- | Use '' | ||
- | '' | ||
=== xfdesktop_file_icon_manager_add_volume_icon() === | === xfdesktop_file_icon_manager_add_volume_icon() === | ||
Use '' | Use '' | ||
- | |||
- | === xfdesktop_file_icon_manager_vfs_monitor_cb() === | ||
- | |||
- | Replace this with a monitor callback for '' | ||
- | |||
- | === xfdesktop_file_icon_manager_listdir_infos_ready_cb() === | ||
- | |||
- | This function will have to be replaced with something similar because we | ||
- | cannot use the list dir job from ThunarVfsJob anymore. | ||
- | |||
- | === xfdesktop_file_icon_manager_listdir_finished_cb() === | ||
- | |||
- | This function will have to be replaced with something similar because we | ||
- | cannot use the list dir job from ThunarVfsJob anymore. | ||
- | |||
- | === xfdesktop_file_icon_manager_listdir_error_cb() === | ||
- | |||
- | This function will have to be replaced with something similar because we | ||
- | cannot use the list dir job from ThunarVfsJob anymore. | ||
- | |||
- | === xfdesktop_file_icon_manager_load_desktop_folder() === | ||
- | |||
- | Asynchronously load the folder using '' | ||
=== xfdesktop_file_icon_manager_volume_changed() === | === xfdesktop_file_icon_manager_volume_changed() === | ||
Line 155: | Line 69: | ||
=== xfdesktop_file_icon_manager_real_init() === | === xfdesktop_file_icon_manager_real_init() === | ||
- | Get rid of the '' | + | Get rid of the global '' |
- | The hash table needs to use either URIs or '' | + | |
- | and equal functions for them. URIs are easier due to the availability of string | + | |
- | hash and equal functions, I guess. | + | |
- | + | ||
- | We'll have to change the '' | + | |
- | to a '' | + | |
- | '' | + | |
- | if the '' | + | |
=== xfdesktop_file_icon_manager_fini() === | === xfdesktop_file_icon_manager_fini() === | ||
Line 190: | Line 96: | ||
Replace the '' | Replace the '' | ||
the '' | the '' | ||
- | |||
- | Remove the '' | ||
==== xfdesktop-file-properties-dialog.{c, | ==== xfdesktop-file-properties-dialog.{c, | ||
Line 234: | Line 138: | ||
Replace the '' | Replace the '' | ||
- | |||
- | === xfdesktop_regular_file_icon_peek_info() === | ||
- | |||
- | Return a '' | ||
- | |||
- | === xfdesktop_regular_file_icon_update_info() === | ||
- | |||
- | TODO: Replace the '' | ||
- | to add a '' | ||
- | |||
- | === xfdesktop_delete_regular_file_finished() === | ||
- | |||
- | Remove. | ||
- | |||
- | === xfdesktop_regular_file_icon_finalize() === | ||
- | |||
- | Call '' | ||
- | new '' | ||
- | |||
- | === xfdesktop_regular_file_icon_tfi_init() === | ||
- | |||
- | Update this to Thunarx 2. Need to set '' | ||
- | and '' | ||
=== xfdesktop_regular_file_icon_peek_pixbuf() === | === xfdesktop_regular_file_icon_peek_pixbuf() === | ||
Line 305: | Line 186: | ||
Here we can simply rewrite the code to use '' | Here we can simply rewrite the code to use '' | ||
- | |||
- | === xfdesktop_delete_file_error() === | ||
- | |||
- | Remove. | ||
- | |||
- | === xfdesktop_delete_file_finished() === | ||
- | |||
- | Remove. | ||
- | |||
- | === xfdesktop_regular_file_icon_delete_file() === | ||
- | |||
- | Instead of '' | ||
- | and forget. | ||
- | |||
- | === xfdesktop_regular_file_icon_rename_file() === | ||
- | |||
- | See previous function. | ||
=== xfdesktop_regular_file_icon_peek_info() === | === xfdesktop_regular_file_icon_peek_info() === | ||
Change the return type to '' | Change the return type to '' | ||
- | |||
- | === xfdesktop_regular_file_icon_update_info() === | ||
- | |||
- | TODO: Check how and where this function is being used and what we can do in order | ||
- | to replace the '' | ||
- | |||
- | === xfdesktop_regular_file_icon_new() === | ||
- | |||
- | Add a '' | ||
- | '' | ||
==== xfdesktop_special_file_icon.{c, | ==== xfdesktop_special_file_icon.{c, |