Xfce Wiki

Sub domains
 

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revisionPrevious revision
Next revision		Previous revision
dev:xfdesktop:port-to-gio [2010/10/17 11:49] – 217.229.117.83dev:xfdesktop:port-to-gio [2010/10/17 13:10] (current) – 217.229.117.83
Line 339: Line 339:
  
 Remove fallback code. Remove fallback code.
- 
 ==== xfdesktop-regular-file-icon.{c,h} ==== ==== xfdesktop-regular-file-icon.{c,h} ====
  
Line 357: Line 356:
 === xfdesktop_delete_regular_file_finished() === === xfdesktop_delete_regular_file_finished() ===
  
-TODO+Remove.
  
 === xfdesktop_regular_file_icon_finalize() === === xfdesktop_regular_file_icon_finalize() ===
Line 397: Line 396:
 === xfdesktop_regular_file_icon_do_drop_dest() === === xfdesktop_regular_file_icon_do_drop_dest() ===
  
-TODO+Rewrite the code based on ''GFileInfo'' and ''GFile''. Use the Thunar D-Bus API 
 +to launch executable files. Use a NULL check with ''g_file_get_parent()'' to 
 +replace the call to ''thunar_vfs_path_is_root()''. Instead of ''thunar_vfs_move_file()'', 
 +''thunar_vfs_copy_file()'' etc. use the Thunar D-Bus API. 
 + 
 +Instead of implement the Thunar D-Bus client manually we could rely on code 
 +generation.
  
 === xfdesktop_regular_file_icon_peek_tooltip() === === xfdesktop_regular_file_icon_peek_tooltip() ===
  
-TODO+What we need is to read the last modification time, the file type and a human readable 
 +version of the size of the file. There are attributes for the modification time, the 
 +file type and the file size in ''GFileInfo''. To humanize the file time we can use 
 +something similar to [[http://git.xfce.org/xfce/thunar/tree/thunar/thunar-util.c#n140|what Thunar is doing]], 
 +for the file size we can use ''g_format_size_for_display()''.
  
 === xfdesktop_regular_file_can_write_parent() === === xfdesktop_regular_file_can_write_parent() ===
  
-TODO+Here we can simply rewrite the code to use ''GFile'' and ''GFileInfo''.
  
 === xfdesktop_delete_file_error() === === xfdesktop_delete_file_error() ===
  
-TODO+Remove.
  
 === xfdesktop_delete_file_finished() === === xfdesktop_delete_file_finished() ===
  
-TODO+Remove.
  
 === xfdesktop_regular_file_icon_delete_file() === === xfdesktop_regular_file_icon_delete_file() ===
  
-TODO+Instead of ''thunar_vfs_unlink_file()'', use the Thunar D-Bus API here. Fire 
 +and forget.
  
 === xfdesktop_regular_file_icon_rename_file() === === xfdesktop_regular_file_icon_rename_file() ===
  
-TODO+See previous function.
  
 === xfdesktop_regular_file_icon_peek_info() === === xfdesktop_regular_file_icon_peek_info() ===
  
-TODO+Change the return type to ''GFileInfo''.
  
 === xfdesktop_regular_file_icon_update_info() === === xfdesktop_regular_file_icon_update_info() ===
Line 434: Line 444:
 === xfdesktop_regular_file_icon_new() === === xfdesktop_regular_file_icon_new() ===
  
-TODO+Add a ''GFile'' parameter, update the code to use ''g_object_ref()'' instead of 
 +''thunar_vfs_info_ref()''.
  
 ==== xfdesktop_special_file_icon.{c,h} ==== ==== xfdesktop_special_file_icon.{c,h} ====