Differences
This shows you the differences between two versions of the page.
Both sides previous revisionPrevious revisionNext revision | Previous revisionNext revisionBoth sides next revision | ||
panel-hig [2008/01/06 03:01] – this probably should have been a draft ongardie | panel-hig [2008/02/15 01:45] – 203.213.7.132 | ||
---|---|---|---|
Line 20: | Line 20: | ||
===== General ===== | ===== General ===== | ||
+ | |||
+ | |||
Line 27: | Line 29: | ||
* //ongardie 2007/12/18 05:51 Screenshots would be helpful [added below] // | * //ongardie 2007/12/18 05:51 Screenshots would be helpful [added below] // | ||
* //ongardie 2007/12/21 01:51 I think I like 2 spaces the best, personally. // | * //ongardie 2007/12/21 01:51 I think I like 2 spaces the best, personally. // | ||
+ | * With GTK+2.12 you can add widgets in a tooltip, and therefore labels with markups, for bold for example. | ||
Line 40: | Line 43: | ||
+ | Or maybe a \t with a configurable (plus sensible default) tab width? | ||
Line 54: | Line 57: | ||
* To clarify, Mike meant to say they display a Help button in their preferences/ | * To clarify, Mike meant to say they display a Help button in their preferences/ | ||
* The three plugins fabian pointed out just show an About item in their context menu. Each of those about dialogs is rather poor, IMHO. Help has to be added manually to the context menu, and I agree with Mike in that its almost always unnecessary. I think the guideline here should be "Help and About context menu items are discouraged. A Help button inside the properties dialog is optional (see ...)" --- // | * The three plugins fabian pointed out just show an About item in their context menu. Each of those about dialogs is rather poor, IMHO. Help has to be added manually to the context menu, and I agree with Mike in that its almost always unnecessary. I think the guideline here should be "Help and About context menu items are discouraged. A Help button inside the properties dialog is optional (see ...)" --- // | ||
+ | |||
==== Menus ==== | ==== Menus ==== | ||
Line 59: | Line 63: | ||
* [draft] Optionally, display a title \\ If you would like to add a title to your menu, set it insensitive and bold, and place it on top of the menu followed by a separator \\ {{http:// | * [draft] Optionally, display a title \\ If you would like to add a title to your menu, set it insensitive and bold, and place it on top of the menu followed by a separator \\ {{http:// | ||
- | * I'm not convinced I like this (and neither is Mike). Perhaps we should discourage menu titles instead. --- // | + | * I'm not convinced I like this. Perhaps we should discourage menu titles instead. --- // |
+ | |||
Line 68: | Line 74: | ||
* [draft] If possible, settings modifications should immediately take effect. Otherwise, settings modifications should take effect when the properties dialog is closed, and the plugin' | * [draft] If possible, settings modifications should immediately take effect. Otherwise, settings modifications should take effect when the properties dialog is closed, and the plugin' | ||
+ | * The sensitive part can be dropped, it just works if the dialog is set modal (see [[http:// | ||
+ | * Indeed in Xfce it is very common to apply changes immediately unless you are making more complex changes. Please avoid insensitivity or modality where possible. --- kalikiana 2008/01/26 17:06 | ||
+ | |||
+ | |||
+ | |||
+ | |||
+ | |||
===== Class B: Button ===== | ===== Class B: Button ===== | ||
Line 89: | Line 102: | ||
* places (1.0 and trunk) | * places (1.0 and trunk) | ||
* If there are no objections by 2008-01-19 (two weeks from now), " | * If there are no objections by 2008-01-19 (two weeks from now), " | ||
- | * [draft] The image should | + | * I don't think the box should have a border/ |
+ | | ||
+ | GdkPixbuf *pixbuf; | ||
+ | |||
+ | size = xfce_panel_plugin_get_size (panel_plugin); | ||
+ | | ||
+ | |||
+ | icon_theme = gtk_icon_theme_get_default (); | ||
+ | pixbuf = gtk_icon_theme_load_icon (icon_theme, | ||
+ | if (G_UNLIKELY (NULL == pixbuf)) | ||
+ | return; | ||
+ | gtk_image_set_from_pixbuf (GTK_IMAGE (panel_plugin-> | ||
+ | g_object_unref (G_OBJECT (pixbuf)); | ||
+ | </ | ||
+ | * Note: this is more a problem of what to do with the size-changed signal | ||
* Use a short label to conserve space | * Use a short label to conserve space | ||
* On the label, use capitalization like a title (e.g., "My Button" | * On the label, use capitalization like a title (e.g., "My Button" |