Xfce Wiki

Sub domains
 

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revisionPrevious revision
Next revision		Previous revision
Next revisionBoth sides next revision
panel-hig [2008/01/06 03:01] – this probably should have been a draft ongardiepanel-hig [2008/03/03 05:34] – removing clutter, pushed comment up with the rest ongardie
Line 20: Line 20:
  
 ===== General ===== ===== General =====
 +
 +
 +
  
  
Line 25: Line 28:
 ==== Tooltips ==== ==== Tooltips ====
   * [rfc] Indentation for sublevel entries should be: 2 spaces? 4 spaces? \t?   * [rfc] Indentation for sublevel entries should be: 2 spaces? 4 spaces? \t?
-    * //ongardie 2007/12/18 05:51 Screenshots would be helpful [added below] // 
     * //ongardie 2007/12/21 01:51 I think I like 2 spaces the best, personally. //     * //ongardie 2007/12/21 01:51 I think I like 2 spaces the best, personally. //
 +    * With GTK+2.12 you can add widgets in a tooltip, and therefore labels with markups, for bold for example.  --- //[[mmassonnet@gmail.com|Mike Massonnet]] 2008/01/06 07:39//
 +    * Or maybe a \t with a configurable (plus sensible default) tab width? -- //anonymous//
  
  
Line 54: Line 58:
       * To clarify, Mike meant to say they display a Help button in their preferences/properties dialog. See battery monitor or clipman.  --- //[[ongardie@gmail.com|Diego Ongaro]] 2008/01/06 01:11//       * To clarify, Mike meant to say they display a Help button in their preferences/properties dialog. See battery monitor or clipman.  --- //[[ongardie@gmail.com|Diego Ongaro]] 2008/01/06 01:11//
     * The three plugins fabian pointed out just show an About item in their context menu. Each of those about dialogs is rather poor, IMHO. Help has to be added manually to the context menu, and I agree with Mike in that its almost always unnecessary. I think the guideline here should be "Help and About context menu items are discouraged. A Help button inside the properties dialog is optional (see ...)" --- //[[ongardie@gmail.com|Diego Ongaro]] 2008/01/06 01:12//     * The three plugins fabian pointed out just show an About item in their context menu. Each of those about dialogs is rather poor, IMHO. Help has to be added manually to the context menu, and I agree with Mike in that its almost always unnecessary. I think the guideline here should be "Help and About context menu items are discouraged. A Help button inside the properties dialog is optional (see ...)" --- //[[ongardie@gmail.com|Diego Ongaro]] 2008/01/06 01:12//
 +
  
 ==== Menus ==== ==== Menus ====
Line 59: Line 64:
  
   * [draft] Optionally, display a title \\ If you would like to add a title to your menu, set it insensitive and bold, and place it on top of the menu followed by a separator \\ {{http://img265.imageshack.us/img265/2880/menutitlepj6.png}}   * [draft] Optionally, display a title \\ If you would like to add a title to your menu, set it insensitive and bold, and place it on top of the menu followed by a separator \\ {{http://img265.imageshack.us/img265/2880/menutitlepj6.png}}
-    * I'm not convinced I like this (and neither is Mike). Perhaps we should discourage menu titles instead. --- //[[ongardie@gmail.com|Diego Ongaro]] 2008/01/06 01:28//+    * I'm not convinced I like this. Perhaps we should discourage menu titles instead. --- //[[ongardie@gmail.com|Diego Ongaro]] 2008/01/06 01:28// 
 + 
  
  
Line 68: Line 75:
  
   * [draft] If possible, settings modifications should immediately take effect. Otherwise, settings modifications should take effect when the properties dialog is closed, and the plugin's widgets should be set insensitive while the dialog is open.   * [draft] If possible, settings modifications should immediately take effect. Otherwise, settings modifications should take effect when the properties dialog is closed, and the plugin's widgets should be set insensitive while the dialog is open.
 +    * The sensitive part can be dropped, it just works if the dialog is set modal (see [[http://library.gnome.org/devel/gtk/2.12/GtkDialog.html#GtkDialogFlags|GtkDialogs flags]]).  Btw, I prefer when the modifications are affected immediately, that's the default habit in most xfce settings dialogs. --- mike 2008/01/10 05:58
 +    * Indeed in Xfce it is very common to apply changes immediately unless you are making more complex changes. Please avoid insensitivity or modality where possible. --- kalikiana 2008/01/26 17:06
 +
 +
 +
 +
 +
  
 ===== Class B: Button ===== ===== Class B: Button =====
Line 89: Line 103:
       * places (1.0 and trunk)       * places (1.0 and trunk)
     * If there are no objections by 2008-01-19 (two weeks from now), "[draft]" should be removed.  --- //[[ongardie@gmail.com|Diego Ongaro]] 2008/01/06 01:43//     * If there are no objections by 2008-01-19 (two weeks from now), "[draft]" should be removed.  --- //[[ongardie@gmail.com|Diego Ongaro]] 2008/01/06 01:43//
-  * [draft] The image should have a size of \\ ''%%size of button - MAX (GtkWidget->style->xthickness, GtkWidget->style->ythickness)%%''+      * I don't think the box should have a border/spacing, but use as much space as possible.  The only space would be the space between the childs, and 2 pixels may be a good default.   --- //[[mmassonnet@gmail.com|Mike Massonnet]] 2008/01/19 18:55// 
 +  * [draft] The image inside the button should be set to the same size as the button (usually the size of the panel) without its padding and border size: \\ <code>  GtkIconTheme *icon_theme; 
 +  GdkPixbuf *pixbuf; 
 + 
 +  size = xfce_panel_plugin_get_size (panel_plugin); 
 +  size -= 2 + 2 * MAX (panel_plugin->button->style->xthickness, panel_plugin->button->style->ythickness); 
 + 
 +  icon_theme = gtk_icon_theme_get_default (); 
 +  pixbuf = gtk_icon_theme_load_icon (icon_theme, "icon-name", size, 0, NULL); 
 +  if (G_UNLIKELY (NULL == pixbuf)) 
 +    return; 
 +  gtk_image_set_from_pixbuf (GTK_IMAGE (panel_plugin->icon), pixbuf); 
 +  g_object_unref (G_OBJECT (pixbuf)); 
 +</code> 
 +    * Note: this is more a problem of what to do with the size-changed signal  --- //[[mmassonnet@gmail.com|Mike Massonnet]] 2008/01/19 18:48//
   * Use a short label to conserve space   * Use a short label to conserve space
   * On the label, use capitalization like a title (e.g., "My Button")   * On the label, use capitalization like a title (e.g., "My Button")