| Both sides previous revisionPrevious revisionNext revision | Previous revision |
| releng:4.14:roadmap:thunar:deprecations [2017/09/04 02:28] – Update deprecations andreldm | releng:4.14:roadmap:thunar:deprecations [2018/06/06 04:55] (current) – Update andreldm |
|---|
| ====== Thunar GTK3 Deprecations ====== | ====== Thunar GTK3 deprecations ====== |
| |
| Deprecations and warnings found in [[https://git.xfce.org/xfce/thunar/commit/?id=9003c61f340c55745fad2452d592fb04cec742ba|9003c61]] | Deprecations and warnings found in [[https://git.xfce.org/xfce/thunar/commit/?id=51fa8fc2dfd7bea356caacd72b69e56925045cff|51fa8fc]] |
| | |
| | Deprecated functions related to the items below will not be handled in this cycle: |
| | * ''gtk_action_*'' |
| | * GAction is not a straightforward replacement |
| | * ''gtk_image_menu_item_*'' |
| | * Gnome decided to remove icons from menu items, Xfce didn't. |
| | * The official workaround (wrap an image and label in a box) results in an ugly left padding. |
| | * ''gtk_radio_action_*'' |
| | * ''gtk_status_icon_*'' |
| | * Gnome decided to drop tray icons, Xfce didn't. |
| | * ''gdk_threads_*'' |
| | * Drawing only on main thread requires lots of refactoring. |
| | * ''gtk_ui_manager_*'' |
| | * GtkBuilder is not a straightforward replacement |
| | * [[https://git.xfce.org/xfce/thunar/commit/?id=e8ccd6fae59d4b93177786252aa65b8ad4efbe93|GTK_STOCK_DISCONNECT]] |
| | * [[https://git.xfce.org/xfce/thunar/commit/?id=baf99226502dda739c97c791b788cf9c62ef2f82|gtk_menu_item_set_right_justified]] |
| |
| <code> | <code> |
| make clean && make 2> build.log | make clean && make 2> build.log |
| | |
| grep "warning:" build.log | wc -l | grep "warning:" build.log | wc -l |
| 740 | 0 (out of 1336 when merged) |
| |
| grep "warning:" build.log | cut -d: -f5 | sort | uniq -c | sort -n -r | grep "warning:" build.log | cut -d: -f5 | sort | uniq -c | sort -n -r |
| 83 ‘gtk_action_get_type’ is deprecated [-Wdeprecated-declarations] | # none |
| 59 ‘gtk_action_group_get_action’ is deprecated [-Wdeprecated-declarations] | |
| 58 ‘gtk_action_get_name’ is deprecated [-Wdeprecated-declarations] | |
| 28 ‘gtk_action_set_visible’ is deprecated [-Wdeprecated-declarations] | |
| 25 ‘gtk_action_set_sensitive’ is deprecated [-Wdeprecated-declarations] | |
| 22 ‘gtk_toggle_action_get_type’ is deprecated [-Wdeprecated-declarations] | |
| 22 ‘gdk_threads_leave’ is deprecated [-Wdeprecated-declarations] | |
| 22 ‘gdk_threads_enter’ is deprecated [-Wdeprecated-declarations] | |
| 20 ‘gtk_image_menu_item_new_with_mnemonic’ is deprecated | |
| 17 ‘gtk_ui_manager_add_ui’ is deprecated [-Wdeprecated-declarations] | |
| 15 ‘gtk_ui_manager_remove_ui’ is deprecated [-Wdeprecated-declarations] | |
| 15 ‘gtk_toggle_action_set_active’ is deprecated [-Wdeprecated-declarations] | |
| 15 ‘gtk_image_menu_item_set_image’ is deprecated [-Wdeprecated-declarations] | |
| 15 ‘gtk_image_menu_item_get_type’ is deprecated | |
| 13 ‘gtk_action_activate’ is deprecated [-Wdeprecated-declarations] | |
| 12 ‘gtk_ui_manager_ensure_update’ is deprecated [-Wdeprecated-declarations] | |
| 10 ‘gtk_action_group_new’ is deprecated [-Wdeprecated-declarations] | |
| 10 ‘gtk_action_create_menu_item’ is deprecated [-Wdeprecated-declarations] | |
| 9 ‘gtk_ui_manager_insert_action_group’ is deprecated [-Wdeprecated-declarations] | |
| 9 ‘gtk_toggle_action_get_active’ is deprecated [-Wdeprecated-declarations] | |
| 8 ‘gtk_widget_modify_text’ is deprecated | |
| 8 ‘gtk_widget_modify_base’ is deprecated | |
| 8 ‘gtk_ui_manager_remove_action_group’ is deprecated [-Wdeprecated-declarations] | |
| 8 ‘gtk_ui_manager_new_merge_id’ is deprecated [-Wdeprecated-declarations] | |
| 8 ‘gtk_radio_action_get_type’ is deprecated [-Wdeprecated-declarations] | |
| 8 ‘gtk_action_new’ is deprecated [-Wdeprecated-declarations] | |
| 8 ‘gtk_action_group_add_action_with_accel’ is deprecated [-Wdeprecated-declarations] | |
| 8 ‘gtk_action_group_add_actions’ is deprecated [-Wdeprecated-declarations] | |
| 7 ‘gtk_ui_manager_add_ui_from_string’ is deprecated [-Wdeprecated-declarations] | |
| 7 ‘gtk_action_group_add_action’ is deprecated [-Wdeprecated-declarations] | |
| 6 ‘gtk_widget_get_style’ is deprecated | |
| 6 ‘gtk_ui_manager_get_widget’ is deprecated [-Wdeprecated-declarations] | |
| 6 ‘gtk_ui_manager_get_action’ is deprecated [-Wdeprecated-declarations] | |
| 6 ‘gtk_action_group_set_translation_domain’ is deprecated [-Wdeprecated-declarations] | |
| 6 ‘gdk_color_parse’ is deprecated | |
| 5 ‘gtk_misc_set_padding’ is deprecated [-Wdeprecated-declarations] | |
| 5 ‘gtk_misc_get_type’ is deprecated [-Wdeprecated-declarations] | |
| 5 ‘gtk_image_new_from_stock’ is deprecated | |
| 5 ‘gtk_action_set_gicon’ is deprecated [-Wdeprecated-declarations] | |
| 4 ‘gtk_ui_manager_get_type’ is deprecated [-Wdeprecated-declarations] | |
| 4 ‘gtk_radio_action_set_current_value’ is deprecated [-Wdeprecated-declarations] | |
| 4 ‘gtk_action_group_remove_action’ is deprecated [-Wdeprecated-declarations] | |
| 4 ‘gtk_action_group_get_type’ is deprecated [-Wdeprecated-declarations] | |
| 4 ‘gtk_action_get_accel_path’ is deprecated [-Wdeprecated-declarations] | |
| 3 ‘GtkStock’ is deprecated [-Wdeprecated-declarations] | |
| 3 ‘gtk_radio_action_set_group’ is deprecated [-Wdeprecated-declarations] | |
| 3 ‘gtk_radio_action_new’ is deprecated [-Wdeprecated-declarations] | |
| 3 ‘gtk_radio_action_get_group’ is deprecated [-Wdeprecated-declarations] | |
| 3 ‘gtk_radio_action_get_current_value’ is deprecated [-Wdeprecated-declarations] | |
| 3 ‘gtk_image_menu_item_new_with_label’ is deprecated | |
| 3 ‘gtk_action_set_tooltip’ is deprecated [-Wdeprecated-declarations] | |
| 3 ‘gtk_action_set_icon_name’ is deprecated [-Wdeprecated-declarations] | |
| 3 ‘gtk_action_get_visible’ is deprecated [-Wdeprecated-declarations] | |
| 2 ‘gtk_widget_reparent’ is deprecated [-Wdeprecated-declarations] | |
| 2 ‘gtk_widget_modify_style’ is deprecated | |
| 2 ‘gtk_ui_manager_new’ is deprecated [-Wdeprecated-declarations] | |
| 2 ‘gtk_ui_manager_get_accel_group’ is deprecated [-Wdeprecated-declarations] | |
| 2 ‘gtk_tree_view_set_rules_hint’ is deprecated [-Wdeprecated-declarations] | |
| 2 ‘gtk_rc_style_new’ is deprecated | |
| 2 ‘gtk_menu_popup’ is deprecated | |
| 2 ‘gtk_icon_source_new’ is deprecated [-Wdeprecated-declarations] | |
| 2 ‘gtk_icon_source_free’ is deprecated [-Wdeprecated-declarations] | |
| 2 ‘gtk_icon_factory_new’ is deprecated [-Wdeprecated-declarations] | |
| 2 ‘gtk_icon_factory_add_default’ is deprecated [-Wdeprecated-declarations] | |
| 2 ‘gtk_drag_begin’ is deprecated | |
| 2 ‘gtk_dialog_set_alternative_button_order’ is deprecated [-Wdeprecated-declarations] | |
| 2 ‘gtk_dialog_get_action_area’ is deprecated [-Wdeprecated-declarations] | |
| 2 ‘gtk_button_set_focus_on_click’ is deprecated | |
| 2 ‘gtk_action_group_list_actions’ is deprecated [-Wdeprecated-declarations] | |
| 2 ‘gtk_action_group_add_radio_actions’ is deprecated [-Wdeprecated-declarations] | |
| 2 ‘gtk_action_get_icon_name’ is deprecated [-Wdeprecated-declarations] | |
| 2 ‘gdk_window_get_pointer’ is deprecated | |
| 2 ‘gdk_screen_get_monitor_geometry’ is deprecated | |
| 2 ‘gdk_screen_get_monitor_at_point’ is deprecated | |
| 2 ‘gdk_display_get_screen’ is deprecated [-Wdeprecated-declarations] | |
| 2 ‘gdk_display_get_n_screens’ is deprecated [-Wdeprecated-declarations] | |
| 1 variable ‘context’ set but not used [-Wunused-but-set-variable] | |
| 1 ‘gtk_widget_push_composite_child’ is deprecated | |
| 1 ‘gtk_widget_pop_composite_child’ is deprecated | |
| 1 ‘gtk_widget_get_state’ is deprecated | |
| 1 ‘gtk_ui_manager_get_action_groups’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gtk_style_render_icon’ is deprecated | |
| 1 ‘gtk_style_lookup_icon_set’ is deprecated | |
| 1 ‘gtk_status_icon_set_visible’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gtk_status_icon_set_tooltip_text’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gtk_status_icon_new_from_icon_name’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gtk_show_uri’ is deprecated | |
| 1 ‘gtk_paint_shadow’ is deprecated | |
| 1 ‘gtk_menu_item_set_right_justified’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gtk_icon_source_set_size_wildcarded’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gtk_icon_source_set_size’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gtk_icon_source_set_pixbuf’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gtk_icon_source_set_icon_name’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gtk_icon_set_unref’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gtk_icon_set_render_icon’ is deprecated | |
| 1 ‘gtk_icon_set_new’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gtk_icon_set_add_source’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gtk_icon_info_get_display_name’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gtk_icon_factory_remove_default’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gtk_icon_factory_add’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gtk_activatable_get_type’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gtk_activatable_get_related_action’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gtk_action_set_stock_id’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gtk_action_set_label’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gtk_action_is_sensitive’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gtk_action_group_set_accel_group’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gtk_action_group_add_toggle_actions’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gtk_action_get_tooltip’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gtk_action_get_sensitive’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gtk_action_get_proxies’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gdk_screen_get_number’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gdk_screen_get_n_monitors’ is deprecated | |
| 1 ‘gdk_screen_get_monitor_plug_name’ is deprecated | |
| 1 ‘gdk_pixbuf_new_from_inline’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gdk_cairo_set_source_color’ is deprecated | |
| 1 comparison between signed and unsigned integer expressions [-Wsign-compare] | |
| </code> | </code> |