| Both sides previous revisionPrevious revisionNext revision | Previous revision |
| releng:4.14:roadmap:thunar:deprecations [2018/01/14 20:39] – Update deprecations andreldm | releng:4.14:roadmap:thunar:deprecations [2018/06/06 04:55] (current) – Update andreldm |
|---|
| ====== Thunar GTK3 Deprecations ====== | ====== Thunar GTK3 deprecations ====== |
| |
| Deprecations and warnings found in [[https://git.xfce.org/xfce/thunar/commit/?id=21538604149f0a1c840ad511b44665c5e5d855b3|2153860]] | Deprecations and warnings found in [[https://git.xfce.org/xfce/thunar/commit/?id=51fa8fc2dfd7bea356caacd72b69e56925045cff|51fa8fc]] |
| |
| GtkAction and GtkUiManager deprecations will not be handled in this cycle. | Deprecated functions related to the items below will not be handled in this cycle: |
| | * ''gtk_action_*'' |
| | * GAction is not a straightforward replacement |
| | * ''gtk_image_menu_item_*'' |
| | * Gnome decided to remove icons from menu items, Xfce didn't. |
| | * The official workaround (wrap an image and label in a box) results in an ugly left padding. |
| | * ''gtk_radio_action_*'' |
| | * ''gtk_status_icon_*'' |
| | * Gnome decided to drop tray icons, Xfce didn't. |
| | * ''gdk_threads_*'' |
| | * Drawing only on main thread requires lots of refactoring. |
| | * ''gtk_ui_manager_*'' |
| | * GtkBuilder is not a straightforward replacement |
| | * [[https://git.xfce.org/xfce/thunar/commit/?id=e8ccd6fae59d4b93177786252aa65b8ad4efbe93|GTK_STOCK_DISCONNECT]] |
| | * [[https://git.xfce.org/xfce/thunar/commit/?id=baf99226502dda739c97c791b788cf9c62ef2f82|gtk_menu_item_set_right_justified]] |
| |
| <code> | <code> |
| |
| grep "warning:" build.log | wc -l | grep "warning:" build.log | wc -l |
| 597 (out of 1336 when merged) | 0 (out of 1336 when merged) |
| |
| grep "warning:" build.log | grep -Ev "gtk_action|gtk_ui_manager|gtk_radio_action|gtk_toggle_action|gtk_activatable_get_related_action" | wc -l | grep "warning:" build.log | cut -d: -f5 | sort | uniq -c | sort -n -r |
| 144 | # none |
| | |
| grep "warning:" build.log | grep -Ev "gtk_action|gtk_ui_manager|gtk_radio_action|gtk_toggle_action|gtk_activatable_get_related_action" | cut -d: -f5 | sort | uniq -c | sort -n -r | |
| 21 ‘gdk_threads_leave’ is deprecated [-Wdeprecated-declarations] | |
| 21 ‘gdk_threads_enter’ is deprecated [-Wdeprecated-declarations] | |
| 20 ‘gtk_image_menu_item_new_with_mnemonic’ is deprecated | |
| 15 ‘gtk_image_menu_item_set_image’ is deprecated [-Wdeprecated-declarations] | |
| 15 ‘gtk_image_menu_item_get_type’ is deprecated | |
| 3 ‘gtk_image_menu_item_new_with_label’ is deprecated | |
| 2 ‘gtk_widget_modify_style’ is deprecated | |
| 2 ‘gtk_widget_get_style’ is deprecated | |
| 2 ‘gtk_rc_style_new’ is deprecated | |
| 2 ‘gtk_menu_popup’ is deprecated | |
| 2 ‘gtk_image_new_from_stock’ is deprecated | |
| 2 ‘gtk_icon_factory_new’ is deprecated [-Wdeprecated-declarations] | |
| 2 ‘gtk_icon_factory_add_default’ is deprecated [-Wdeprecated-declarations] | |
| 2 ‘gtk_drag_begin’ is deprecated | |
| 2 ‘gtk_dialog_set_alternative_button_order’ is deprecated [-Wdeprecated-declarations] | |
| 2 ‘gtk_dialog_get_action_area’ is deprecated [-Wdeprecated-declarations] | |
| 2 ‘gtk_button_set_focus_on_click’ is deprecated | |
| 2 ‘gdk_window_get_pointer’ is deprecated | |
| 2 ‘gdk_screen_get_monitor_geometry’ is deprecated | |
| 2 ‘gdk_screen_get_monitor_at_point’ is deprecated | |
| 1 variable ‘context’ set but not used [-Wunused-but-set-variable] | |
| 1 ‘gtk_widget_push_composite_child’ is deprecated | |
| 1 ‘gtk_widget_pop_composite_child’ is deprecated | |
| 1 ‘GtkStock’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gtk_status_icon_set_visible’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gtk_status_icon_set_tooltip_text’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gtk_status_icon_new_from_icon_name’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gtk_show_uri’ is deprecated | |
| 1 ‘gtk_paint_shadow’ is deprecated | |
| 1 ‘gtk_menu_item_set_right_justified’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gtk_icon_source_set_icon_name’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gtk_icon_source_new’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gtk_icon_source_free’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gtk_icon_set_unref’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gtk_icon_set_new’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gtk_icon_set_add_source’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gtk_icon_info_get_display_name’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gtk_icon_factory_remove_default’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gtk_icon_factory_add’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gtk_activatable_get_type’ is deprecated [-Wdeprecated-declarations] | |
| 1 ‘gdk_pixbuf_new_from_inline’ is deprecated [-Wdeprecated-declarations] | |
| </code> | </code> |